-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stricter code checks (TypeScript and Lint) #404
Conversation
Related information: https://code.visualstudio.com/blogs/2019/05/23/strict-null |
… etc. (activated TSLint project types)
"strictNullChecks": true, "strictPropertyInitialization": true
… formatting) errors
4f5ce31
to
4f50b20
Compare
This PR is reasonably consensual, I am hoping we will reach an agreement to merge it. |
Note that TypeScript 3.6 will provide strongly-typed iterators and generators, which means that the returned values of Redux-Saga |
Hello Pierre @panaC if you have time, I would appreciate your input / review on this PR. The code alterations are mostly lint-related, there are no changes in execution logic. I think that stricter type checking and linting is needed in the Thorium codebase, so that we can continue implementing improvements / refactoring more efficiently. Note that the other PR #475 |
This PR removes a few
any
types, removes unused variables, etc. (see linting rules)Note that strict
null
/undefined
checks are implemented in a separate PR: #475