-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privacy issue: annotations "creator" is a person's name / nickname #2628
Comments
interesting yes. the creator's name is optional but really useful, and Thorium should export it when the user agrees. Label EN: "Do you want your name to be included in your annotations when exported?" (yes/no), no default. |
The creator id will be automatically generated as a UUID if the flag is set to Yes, and stored. |
Hello @llemeurfr @danielweck , i'm suggestiing to not set the creator name from the Operating System username info and let user define it. The creator name is only useful on annotation export. So That didn't make sense to save it locally in db when the creator name in annotation set is not exported and shared to everyone. |
@panaC in a previous comment, I proposed a process to ask the user if he wanted to have his name stored in the db and exported with his notes. Did you take it into account? |
@llemeurfr yes I did |
@llemeurfr I will working with Arthur to add a description message below creator title section to explain to user, as said by Daniel, that this information will be shared with the annotation set export format. As I understand the original Daniel issue is more to explain to the user what is the purpose of the creator name than to add a new key/value flag in db to enable or not an another db state value. May I'm wrong |
@llemeurfr if the user doesn't want/can shared personnal info to the annotation set export file, it is better to include a checkbox in the export confirmation modal below the textedit title and above the save as confirmation button. |
@llemeurfr 2 solutions : The first, the user choose a name that can be shareable and not private, and choose to export any annotation set with this nickname. The second, the user want to secretly share a specific annotation set with his specific notes taken during his lecture. He wish to specify a name of the export and uncheck a box to not copy his nickname to this special annotation set export, and now share it anonymously to everyone for this special occasion only. In this case an export form modal with an anonymity checkbox is more useful than a checkbox in settings. |
ok so let's implement a simple solution:
We don't need to add a check box at export to allow the user to "anonymize" his export. This is an opt-in functionality: most of the time, the creator field in the settings will be left empty, therefore there will be not creator. |
@arthur-lemeur We have to work on Monday to add a description text under the title "creator", as Laurent wishes. |
…2628) for security reason do not export creator name in annotation set from os username and let the user to set his own nickname.
Suggestion: somehow inform Thorium user that personal information is stored only the user's local database, and user can opt-in (not opt-out) to include personal information when exporting annotations.
The text was updated successfully, but these errors were encountered: