Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privacy issue: annotations "creator" is a person's name / nickname #2628

Closed
danielweck opened this issue Oct 30, 2024 · 10 comments · May be fixed by #2712
Closed

privacy issue: annotations "creator" is a person's name / nickname #2628

danielweck opened this issue Oct 30, 2024 · 10 comments · May be fixed by #2712
Assignees

Comments

@danielweck
Copy link
Member

Suggestion: somehow inform Thorium user that personal information is stored only the user's local database, and user can opt-in (not opt-out) to include personal information when exporting annotations.

@llemeurfr
Copy link
Contributor

llemeurfr commented Nov 4, 2024

interesting yes. the creator's name is optional but really useful, and Thorium should export it when the user agrees.
@panaC, can we add a flag to the Settings / General?
Same look as the session flag, below this one.

Label EN: "Do you want your name to be included in your annotations when exported?" (yes/no), no default.
And below: "If yes, enter your name:" + input field.

@llemeurfr
Copy link
Contributor

The creator id will be automatically generated as a UUID if the flag is set to Yes, and stored.

@panaC panaC assigned panaC and unassigned llemeurfr Nov 5, 2024
@panaC
Copy link
Member

panaC commented Dec 10, 2024

Hello @llemeurfr @danielweck , i'm suggestiing to not set the creator name from the Operating System username info and let user define it. The creator name is only useful on annotation export. So That didn't make sense to save it locally in db when the creator name in annotation set is not exported and shared to everyone.

@panaC panaC closed this as completed in 704c10e Dec 10, 2024
@llemeurfr
Copy link
Contributor

@panaC in a previous comment, I proposed a process to ask the user if he wanted to have his name stored in the db and exported with his notes. Did you take it into account?

@panaC
Copy link
Member

panaC commented Dec 10, 2024

@llemeurfr yes I did

@panaC
Copy link
Member

panaC commented Dec 10, 2024

@llemeurfr I will working with Arthur to add a description message below creator title section to explain to user, as said by Daniel, that this information will be shared with the annotation set export format. As I understand the original Daniel issue is more to explain to the user what is the purpose of the creator name than to add a new key/value flag in db to enable or not an another db state value. May I'm wrong

@panaC
Copy link
Member

panaC commented Dec 10, 2024

@llemeurfr if the user doesn't want/can shared personnal info to the annotation set export file, it is better to include a checkbox in the export confirmation modal below the textedit title and above the save as confirmation button.

@panaC
Copy link
Member

panaC commented Dec 10, 2024

@llemeurfr 2 solutions : The first, the user choose a name that can be shareable and not private, and choose to export any annotation set with this nickname. The second, the user want to secretly share a specific annotation set with his specific notes taken during his lecture. He wish to specify a name of the export and uncheck a box to not copy his nickname to this special annotation set export, and now share it anonymously to everyone for this special occasion only. In this case an export form modal with an anonymity checkbox is more useful than a checkbox in settings.

@llemeurfr
Copy link
Contributor

ok so let's implement a simple solution:

  • in the Settings / General, there is a new text field labelled "User name".
  • Below is this file an explanation: "This will be used as the creator of the notes you may export; enter a nickname or leave it empty if you prefer.".
  • When exporting notes, if not empty, the value is used as value for "creator". In this case the creator type is always "Person" (we do not deal with Organizations in Thorium). If empty, the creator property is not included.

We don't need to add a check box at export to allow the user to "anonymize" his export. This is an opt-in functionality: most of the time, the creator field in the settings will be left empty, therefore there will be not creator.

@llemeurfr llemeurfr reopened this Dec 10, 2024
@panaC
Copy link
Member

panaC commented Dec 10, 2024

@arthur-lemeur We have to work on Monday to add a description text under the title "creator", as Laurent wishes.

panaC added a commit that referenced this issue Dec 18, 2024
…2628)

for security reason do not export creator name in annotation set from os
username and let the user to set his own nickname.
@panaC panaC closed this as completed Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants