Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug AMP Validator Errors #11

Closed
11 tasks done
edm00se opened this issue Oct 25, 2016 · 2 comments
Closed
11 tasks done

Debug AMP Validator Errors #11

edm00se opened this issue Oct 25, 2016 · 2 comments
Milestone

Comments

@edm00se
Copy link
Owner

edm00se commented Oct 25, 2016

Can't use the Google AMP CDN until they're resolved ☹️ . It must be all that new stuff I added. At least it's still pretty darned fast.

  • scripts (custom, site specific)
  • iframe
    • embeds
    • YouTube
    • asciicast
  • images
    • image content
    • site images
    • emojis (formerly handled by jemoji, now just the emojis embedded into the post's markdown)
  • disqus comments - tried a couple versions, not liking whatever I do :-/

ref:

@edm00se edm00se added this to the 2.0 milestone Oct 25, 2016
@edm00se
Copy link
Owner Author

edm00se commented Oct 27, 2016

Only need to solve gist embedding now.
Solved... by moving to all native code in markdown code fenced blocks... yuck.

Strictly speaking, the Search page will fail validation, unless I find a way to load the scripts for the search in a compliant manner.

@edm00se edm00se closed this as completed Oct 28, 2016
@edm00se
Copy link
Owner Author

edm00se commented Mar 16, 2017

Latest: switching to using a jekyll include of an amp-iframe which calls out to a gist embedding page (on another domain I own) does the trick. Outlined here:

ampproject/amp-by-example#90 (comment)

edm00se added a commit that referenced this issue Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant