Fixed path in resource_string to use package for compatibility with older versions #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manan-memon
force-pushed
the
manan/fix-importlibresource-package-path
branch
from
c139a7b
to
5cc106f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with using the
__name__variable while reading files via theimportlib-resourcelibrary in older versions (e.g., 3.1.2) results in the following error:This PR updates the reference to
__package__instead of__name__to ensure compatibility with older versions of the library.Changes have been tested on both versions 3.1.2 and 6.4.5 (latest) of
importlib-resourcesand are working correctly.