Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add status updates for interactions in the student view #26

Merged
merged 9 commits into from
Oct 12, 2023

Conversation

mariajgrimaldi
Copy link
Contributor

@mariajgrimaldi mariajgrimaldi commented Sep 27, 2023

Description

This PR adds new fields to inform students about their interaction status with the problem. Have they answered? What's their score? Since some H5P components do not explicitly show this.

We decided to use two states:
Not attempted: the default
Completed: when a student submits a problem, the status is updated to this one.

When the instructor cleans the student status, the state resets to Not attempted. Regarding the score, we're currently showing what the H5P content returns as raw score and max score. When the problem is not scored, then just the submission status is shown.

How to test

  1. Install this branch into your environment
  2. Use H5P in your course as specified in the README file:
    image
  3. Download some H5P problems, like true/false questions.
  4. Now, configure your content into your course. For this example I used the default values for the grading system.
  5. As a student, go into your course and complete the problem. Now, you'll see a text showing the state of the submission:
    image
    Where the max score is the one configured in the Studio Edit view. When the problem is not scored, then nothing is shown.

@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review September 27, 2023 14:00
@mariajgrimaldi
Copy link
Contributor Author

These changes conflict with #27 since we're using similar definitions. Depending on which is merged first, @Ian2012 and I will make the necessary changes to solve the conflicts. Thanks!

@BryanttV
Copy link
Contributor

@mariajgrimaldi, When I try to delete a student's status I get the following error

  File "/openedx/edx-platform/lms/djangoapps/instructor/enrollment.py", line 382, in _fire_score_changed_for_block
    max_score = block.max_score()
TypeError: 'int' object is not callable

Apparently max_score is a method, and is being overwritten.

@mariajgrimaldi
Copy link
Contributor Author

@BryanttV: thanks! Can you try again?

@BryanttV
Copy link
Contributor

Now it works fine!

h5pxblock/h5pxblock.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ziafazal
Copy link
Contributor

@mariajgrimaldi could you please rebase it with master?

@mariajgrimaldi
Copy link
Contributor Author

mariajgrimaldi commented Oct 11, 2023

Hi there folks @ziafazal @BryanttV: I made some changes according to the new commits in the master branch that affected this PR. I also updated the cover letter reflecting those. Could you check again? Thank you!

@BryanttV
Copy link
Contributor

@mariajgrimaldi, By default, the score displayed is always (1.0/x.0), in this case: (1.0/100.0). Shouldn't the score be 0?
image

@mariajgrimaldi
Copy link
Contributor Author

@BryanttV: check again :)

@BryanttV
Copy link
Contributor

@mariajgrimaldi, Perfect, LGTM!

@ziafazal ziafazal merged commit 67ef880 into edly-io:master Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants