feat: allow to view in CMS #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariajgrimaldi
suggested changes
Oct 11, 2023
Ian2012
force-pushed
the
cag/view-in-cms
branch
from
9feaef9
to
b0df6c3
Compare
|
@ziafazal can you review this PR? |
|
Hi @ziafazal! Friendly ping on this :) |
Hi @mariajgrimaldi & @Ian2012 Sorry for the delay. I'll review it this week. |
ziafazal
requested changes
Dec 7, 2023
| @@ -200,16 +199,12 @@ def get_context_studio(self): | |||
| "h5p_xblock": self, | |||
| } | |||
|
|
|||
| def author_view(self, context=None): | |||
There was a problem hiding this comment.
If we are removing author_view we should remove author_view.html and also relevant translations in *.po files of all supported languages.
Ian2012
force-pushed
the
cag/view-in-cms
branch
from
a7c6069
to
817d6ee
Compare
Ian2012
force-pushed
the
cag/view-in-cms
branch
from
817d6ee
to
1e8ae48
Compare
ziafazal
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to preview of the h5p content in the CMS. This will avoid the need for instructors to publish the unit to reproduce the h5p content.
This change is part of a series of improvements to the h5pxblock.
Before
After