-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to view in CMS #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a before and after in the cover letter? Also, can we include why are we proposing this change?
9feaef9
to
b0df6c3
Compare
@ziafazal can you review this PR? |
Hi @ziafazal! Friendly ping on this :) |
Hi @mariajgrimaldi & @Ian2012 Sorry for the delay. I'll review it this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ian2012 overall looks good. Just one thing needs to be addressed?
@@ -200,16 +199,12 @@ def get_context_studio(self): | |||
"h5p_xblock": self, | |||
} | |||
|
|||
def author_view(self, context=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are removing author_view
we should remove author_view.html
and also relevant translations in *.po files of all supported languages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
a7c6069
to
817d6ee
Compare
817d6ee
to
1e8ae48
Compare
Description
This PR allows to preview of the h5p content in the CMS. This will avoid the need for instructors to publish the unit to reproduce the h5p content.
This change is part of a series of improvements to the h5pxblock.
Before
After