-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for due dates #24
Conversation
1ae1ed7
to
3ebc47f
Compare
h5pxblock/h5pxblock.py
Outdated
""" | ||
Return True if the due date has passed. | ||
""" | ||
due = self.due |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is a new due
variable created?
h5pxblock/h5pxblock.py
Outdated
@@ -289,12 +289,20 @@ def result_handler(self, data, suffix=''): | |||
Handler to injest results when h5p content triggers completion or rescorable events | |||
""" | |||
save_completion, save_score = False, False | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the trailing whitespace
d96137a
to
bdbfcb8
Compare
@Ian2012 acceptance tests on you PR are failing could you please rebase it with master? |
44d82d2
to
fa7009c
Compare
{% if h5pblock.is_past_due %} | ||
<div class='h5p-warning'> | ||
<h3>{% trans "The due date for this subsection has passed. Your response will be recorded, but not graded." %}<h3> | ||
</div> | ||
{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we update translations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! I see you folks did it already. Thanks!
d320991
to
8315913
Compare
54e6bd0
to
9ddb41f
Compare
9ddb41f
to
230844d
Compare
230844d
to
d249ef0
Compare
@Ian2012 are good to merge this one? |
@ziafazal yes, it's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
This PR makes the user unable to store their progress in the XBlock if the due date has passed.
Testing instructions
After: