feat: add support for due dates #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian2012
force-pushed
the
cag/due-date-support
branch
2 times, most recently
from
1ae1ed7
to
3ebc47f
Compare
BryanttV
reviewed
Sep 27, 2023
h5pxblock/h5pxblock.py
Outdated
| """ | ||
| Return True if the due date has passed. | ||
| """ | ||
| due = self.due |
There was a problem hiding this comment.
Why is a new due variable created?
h5pxblock/h5pxblock.py
Outdated
| @@ -289,12 +289,20 @@ def result_handler(self, data, suffix=''): | |||
| Handler to injest results when h5p content triggers completion or rescorable events | |||
| """ | |||
| save_completion, save_score = False, False | |||
|
|
|||
There was a problem hiding this comment.
Please remove the trailing whitespace
Ian2012
force-pushed
the
cag/due-date-support
branch
2 times, most recently
from
d96137a
to
bdbfcb8
Compare
BryanttV
approved these changes
Sep 27, 2023
|
@Ian2012 acceptance tests on you PR are failing could you please rebase it with master? |
Ian2012
force-pushed
the
cag/due-date-support
branch
4 times, most recently
from
44d82d2
to
fa7009c
Compare
Comment on lines
+11
to
+18
| {% if h5pblock.is_past_due %} | ||
| <div class='h5p-warning'> | ||
| <h3>{% trans "The due date for this subsection has passed. Your response will be recorded, but not graded." %}<h3> | ||
| </div> | ||
| {% endif %} |
There was a problem hiding this comment.
should we update translations?
There was a problem hiding this comment.
Good! I see you folks did it already. Thanks!
Ian2012
force-pushed
the
cag/due-date-support
branch
from
d320991
to
8315913
Compare
Ian2012
force-pushed
the
cag/due-date-support
branch
from
54e6bd0
to
9ddb41f
Compare
Ian2012
force-pushed
the
cag/due-date-support
branch
from
9ddb41f
to
230844d
Compare
Ian2012
force-pushed
the
cag/due-date-support
branch
from
230844d
to
d249ef0
Compare
|
@Ian2012 are good to merge this one? |
|
@ziafazal yes, it's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the user unable to store their progress in the XBlock if the due date has passed.
Testing instructions
After:
