feat: add translations of es_419 and es_ES
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanttV
force-pushed
the
bav/add-translations
branch
from
aa7fd2f
to
93becfc
Compare
| template_str = self.resource_string(template_path) | ||
| template = Template(template_str) | ||
| return template.render(Context(context)) | ||
| return loader.render_django_template( |
There was a problem hiding this comment.
Can you add docstrings here? thanks!
BryanttV
changed the title
es_419 and es_ESes_419 and es_ES
BryanttV
force-pushed
the
bav/add-translations
branch
from
93becfc
to
644ec41
Compare
mariajgrimaldi
approved these changes
Aug 30, 2023
|
@BryanttV thanks for creating this PR. However, it appears E2E tests are failing on it. |
|
@ziafazal: I added xblock-utils that seem missing in the testing environment. Can we rerun the tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds translations of
es_419andes_ESto the H5P XBlock.How To Test
(Account → Site Preferences → Site Language). Set it to "Spanish (Latin America)"Using translations commands
A
Makefilewas created that includes the necessary commands (based on the edX cookie-cutter) to extract and compile the translations.make extract_translations, this will update the strings to be translated inh5pxblock/locale/en/LC_MESSAGES/text.poh5pxblock/locale/, ie:h5pxblock/locale/es_419/LC_MESSAGES/, and create yourtext.pofile, based on the file generated above.make compile_translations, this will generate thetext.mofile in all created language folders.Screenshots