fix: get marketing and auth urls from site configurations #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faraz32123
reviewed
Nov 3, 2023
| @@ -23,6 +24,9 @@ def register_redirect_to_lms(request): | |||
| This view redirects to the LMS register view. It is used to temporarily keep the old | |||
| Studio signup url alive. | |||
| """ | |||
| configuration_helpers.get_value( | |||
| "FRONTEND_REGISTER_URL", settings.FRONTEND_REGISTER_URL | |||
| ) | |||
| register_url = '{register_url}{params}'.format( | |||
| register_url=settings.FRONTEND_REGISTER_URL, | |||
There was a problem hiding this comment.
we are still getting it from settings
Ali-Salman29
force-pushed
the
alisalman/fix-multisites-urls
branch
from
c9b2b7f
to
a64c89c
Compare
Ali-Salman29
force-pushed
the
alisalman/fix-multisites-urls
branch
2 times, most recently
from
6d21ab5
to
bcfb486
Compare
Ali-Salman29
force-pushed
the
alisalman/fix-multisites-urls
branch
from
bcfb486
to
db884c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.