Orchestra: changes in when the orchestra_parent_knows_us flag is set #17
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws_us flag only upon reception of a DAO ACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the child always set the orchestra_parent_knows_us flag when getting a MAC-level ACK to the DAO packet. However, the DAO packet may be dropped by the higher layers, and a route to the child not added - for instance, because the routing table is already full!
This PR aims to improve this logic, and in case DAO ACKs are enabled, set the orchestra_parent_knows_us flag only upon reception of a DAO ACK.
This is a draft PR, as it's not clear whether this tradeoff is worth doing in practice.