Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better stack traces #480

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Conversation

paulanthonywilson
Copy link
Contributor

Adds the location: :keep option to the quote in the __using__/1 macro. These gives better stack traces if and when unexpected errors are raised somewhere in the code. Otherwise the stack tops out at use HTTPoison.Base in HTTPoison or whever the base is being used.

The PR also includes:

  • updating ssl_verify_fun as otherwise I can't get things to compile (at least with Elixir 1.5 / Erlang 26 on OS X and Ubuntu)
  • Fixed a couple of tests that I think are failing for me because of Map key ordering changing with Elixir 1.5 (or is it Erlang 26?)

Oh, and it looks like mix format has gone and changed a bunch of charlist strings to use the ~c sigil. ¯\(ツ)/¯ . I can revert that if you like.

"test ssl config tests https scheme" in HTTPoisonTest is still failing in Elixir 1.5 but I don't know why. Something to do with httparrot and ssl.

@edgurgel
Copy link
Owner

edgurgel commented Nov 7, 2023

Thank you! This is great

@edgurgel edgurgel merged commit 0b8c71a into edgurgel:main Nov 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants