Updates the ssl option to add settings rather than replace them
#466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgurgel
approved these changes
Oct 25, 2022
It should be pretty simple - the only question is whether to use the genuine Chromium version that seems to require building from scratch 😞 (and thus keeping copies of everything) , or one of the random copies that may or may not be/continue to be legitimate / present. |
|
LGTM! Do you want to autosquash those fixups? |
As per issue edgurgel#458, passing the `ssl` option completely overrides all settings, rather than just overwriting the "sub"-setting that was specified. Eg `ssl: [{:verions, [:'tlsv1.2']}]` disabled all TLS settings rather than just requiring TLSv1.2. This commit changes HTTPoison's behaviour to merge the `ssl` settings with my best-guess at what the defaults are. Since it may be a breaking change, it also adds a new `ssl_override` option that can be used by anyone wishing to maintain the existing behaviour. This resolves edgurgel#458.
ShahneRodgers
force-pushed
the
ssl-merge-options
branch
from
2e9d254 to
14507b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #458, passing the
ssloption completely overrides all settings, rather than just overwriting the "sub"-setting that was specified. Egssl: [{:verions, [:'tlsv1.2']}]disabled all TLS settings rather than just requiring TLSv1.2.This commit changes HTTPoison's behaviour to merge the
sslsettings with my best-guess at what the defaults are. Since it may be a breaking change, it also adds a newssl_overrideoption that can be used by anyone wishing to maintain the existing behaviour.This resolves #458.