Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhancements of LatestScheduleActionRecordsByJobName #922

Conversation

jackchenjc
Copy link
Contributor

@jackchenjc jackchenjc commented Aug 20, 2024

  • Replaced LatestScheduleActionRecords API to LatestScheduleActionRecordsByJobName
  • Added WithId() method for ScheduleAction interface
  • Fixed typos

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@jackchenjc jackchenjc marked this pull request as draft August 20, 2024 09:29
- Replaced LatestScheduleActionRecords API to LatestScheduleActionRecordsByJobName
- Added WithId() method for ScheduleAction interface
- Fixed typos

Signed-off-by: Jack Chen <jack@iotechsys.com>
@jackchenjc jackchenjc force-pushed the latest_schedule_action_records_by_job_name branch from bd66c46 to a299cae Compare August 20, 2024 09:38
@jackchenjc jackchenjc changed the title feat: Replace LatestScheduleActionRecords to LatestScheduleActionRecordsByJobName feat: Enhancements of LatestScheduleActionRecordsByJobName Aug 20, 2024
@jackchenjc jackchenjc marked this pull request as ready for review August 20, 2024 09:43
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.57%. Comparing base (424ac31) to head (a299cae).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
+ Coverage   67.48%   67.57%   +0.09%     
==========================================
  Files         104      104              
  Lines        4299     4311      +12     
==========================================
+ Hits         2901     2913      +12     
  Misses       1150     1150              
  Partials      248      248              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 44d6dc1 into edgexfoundry:main Aug 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants