-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance the auth hook func to support external JWT #811
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
==========================================
+ Coverage 45.86% 46.44% +0.57%
==========================================
Files 59 62 +3
Lines 3519 3626 +107
==========================================
+ Hits 1614 1684 +70
- Misses 1786 1820 +34
- Partials 119 122 +3 ☔ View full report in Codecov by Sentry. |
Resolves edgexfoundry#810. Enhance the auth middleware func to support external JWT verifcation. Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
Add the missing import in auth_middleware_no_ziti. Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
606c2bb
to
d68de5a
Compare
Define SecretStoreAuthenticationHandlerFunc in separate file Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #810. Enhance the auth middleware func to support external JWT verifcation.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)