Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to go-1.23, Linter1.61.0 #767

Merged
merged 1 commit into from
Oct 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
linters:
disable:
enable:
- gosec
- gosec
linters-settings:
gosec:
excludes:
# G115: integer overflow conversion
# exclude the rule since it tends to be false positive
- G115
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ lint:
@if [ "z${ARCH}" = "zx86_64" ] && which golangci-lint >/dev/null ; then golangci-lint run --config .golangci.yml ; else echo "WARNING: Linting skipped (not on x86_64 or linter not installed)"; fi

install-lint:
sudo curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $$(go env GOPATH)/bin v1.54.2
sudo curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $$(go env GOPATH)/bin v1.61.0

test: unittest lint
$(GO) vet ./...
Expand Down
2 changes: 1 addition & 1 deletion bootstrap/handlers/httpserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ func (b *HttpServer) BootstrapHandler(
for t.HasNotElapsed() {
ln, listenErr := zitiCtx.Listen(ozServiceName)
if listenErr != nil {
err = fmt.Errorf("could not bind service " + ozServiceName + ": " + listenErr.Error())
err = fmt.Errorf("could not bind service %s: %s", ozServiceName, listenErr.Error())
t.SleepForInterval()
} else {
zc.c = &zitiCtx
Expand Down
2 changes: 2 additions & 0 deletions bootstrap/messaging/testcerts_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ kX0EMnYch0e7urs9o1M6JWJGlWZQxgVnxekbFDPfRelR1m0zFnbfXG2rnfuRpVEL
uXOR
-----END CERTIFICATE-----
`

// #nosec G101
const testClientKey = `-----BEGIN RSA PRIVATE KEY-----
MIIEpAIBAAKCAQEA4TlobJoFgNoCc5Znb0OzVoMypoay1RSTAhnU0arpHVugUMZM
O6oxSt371MN+e4cUxoes4uhNqeVG7AxUkdMCNJbzjAmJeDQtLKYHcY4YI30HHWCW
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/edgexfoundry/go-mod-bootstrap/v3

go 1.21
go 1.23

require (
github.com/eclipse/paho.mqtt.golang v1.5.0
Expand Down