Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Query readings without pagination offset #5057

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

weichou1229
Copy link
Member

Query readings without pagination offset to prevent large dataset query and count.

Signed-off-by: bruce weichou1229@gmail.com
(cherry picked from commit 1a89671151ac64faeeb06f70b556460da8f76616)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) not impact
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) not impact

Testing Instructions

Run core service and query reading without offset, the core data will not use SQL count and offset to prevent performance issue.

New Dependency Instructions (If applicable)

Query readings without pagination offset to prevent large dataset query and count.

Signed-off-by: bruce <weichou1229@gmail.com>
(cherry picked from commit 1a89671151ac64faeeb06f70b556460da8f76616)
@weichou1229 weichou1229 requested a review from cloudxxx8 January 17, 2025 02:54
Copy link

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 38.70968% with 38 lines in your changes missing coverage. Please review.

Project coverage is 28.15%. Comparing base (19dbf70) to head (ccee771).

Files with missing lines Patch % Lines
internal/core/data/application/reading.go 29.62% 34 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5057      +/-   ##
==========================================
+ Coverage   28.03%   28.15%   +0.11%     
==========================================
  Files         256      256              
  Lines       18520    18536      +16     
==========================================
+ Hits         5193     5218      +25     
+ Misses      12129    12097      -32     
- Partials     1198     1221      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit fdc408d into edgexfoundry:main Jan 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants