Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused users from the database user creation #5043

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jinlinGuan
Copy link
Contributor

close #4990

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

close edgexfoundry#4990

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
Copy link

sonarqubecloud bot commented Jan 9, 2025

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.11%. Comparing base (9ac3255) to head (63893e0).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5043   +/-   ##
=======================================
  Coverage   28.11%   28.11%           
=======================================
  Files         256      256           
  Lines       18462    18462           
=======================================
  Hits         5191     5191           
  Misses      12071    12071           
  Partials     1200     1200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 0d11a11 into edgexfoundry:main Jan 9, 2025
7 checks passed
@jinlinGuan jinlinGuan deleted the issue-4990 branch January 9, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove core_command and app_rules_engine users from the database user creation
3 participants