Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace API route constants #5037

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

jinlinGuan
Copy link
Contributor

block by: edgexfoundry/go-mod-core-contracts#965

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

block by: edgexfoundry/go-mod-core-contracts#965

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
@jinlinGuan jinlinGuan force-pushed the contracts-issue-956 branch from c6ae1de to c7830c8 Compare January 6, 2025 03:12
Copy link

sonarqubecloud bot commented Jan 6, 2025

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Project coverage is 28.05%. Comparing base (0ef5369) to head (c7830c8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/support/notifications/router.go 0.00% 20 Missing ⚠️
internal/core/metadata/router.go 0.00% 19 Missing ⚠️
internal/core/data/router.go 0.00% 16 Missing ⚠️
internal/support/scheduler/router.go 0.00% 7 Missing ⚠️
internal/core/keeper/router.go 0.00% 5 Missing ⚠️
internal/core/command/router.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5037   +/-   ##
=======================================
  Coverage   28.05%   28.05%           
=======================================
  Files         243      243           
  Lines       17602    17602           
=======================================
  Hits         4938     4938           
  Misses      11536    11536           
  Partials     1128     1128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 027efad into edgexfoundry:main Jan 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants