fix: Add backwards compatability for Device System Events

[lenny-goodell]

fixes #4117

Signed-off-by: Leonard Goodell leonard.goodell@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

• I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
• I am not introducing a new dependency (add notes below if you are)
• I have added unit tests for the new feature or bug fix (if not, why?)
• I have fully tested (add details below) this the new feature or bug fix (if not, why?)
• I have opened a PR for the related docs change (if not, why?)
  feat: Document Core Metadata Device System Events edgex-docs#830

Testing Instructions

Run Non-secure EdgeX Stack from compose builder

make run no-secty ds-virtual ds-rest`

Stop Core Metadata
In Consul, remove MessageQueue configuration for Core Metadata
Using the branch for this PR
Remove MessageQueue and RequireMessageBus configuration from TOML file
Build Core Metadata docker image locally
Modify generated compose file to switch Core Metadata image to be local image
Restart local Core Metadata image using modified compose file

make up

Verify Core Metadata logs don't show anything about MessageBus and started without error
Using Edgex UI delete a device
Verify that Core Metadata logs show warning that the Device System Event couldn't be published.

Stop Core Metadata image
Remove Core Metadata config from Consul
Restore local TOML file
Rebuild local Core Metadata image
Restart local Core Metadata image using modified compose file

make up

Verify Core Metadata logs do show MessageBus connection info and started without error
Using Consul set Core Metadata log level to Debug
Using Edgex UI delete a device
Verify that Core Metadata logs show debug message that the Device System Event was published.

New Dependency Instructions (If applicable)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.5% Duplication

[codecov-commenter]

Codecov Report

Merging #4121 (20b0bae) into main (e18dbdc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4121   +/-   ##
=======================================
  Coverage   43.66%   43.66%           
=======================================
  Files         120      120           
  Lines       10617    10617           
=======================================
  Hits         4636     4636           
  Misses       5594     5594           
  Partials      387      387           

Impacted Files	Coverage Δ
internal/core/metadata/application/device.go	13.09% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[cloudxxx8]

LGTM

[farshidtz]

Didn't get a chance to review this.

Couldn't we just check if MessageQueue or MessageQueue.protocol are set, then assume message bus is required?

edgex-go/cmd/core-metadata/res/configuration.toml

Lines 64 to 65 in e3ca38a

	[MessageQueue]
	Protocol = "redis"

[lenny-goodell]

I considered that, but that is ambiguous as to if it is missing because of old configuration or just bad configuration. I prefeed it to be explicate.