Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(adr): core metadata CPE #724

Closed
wants to merge 2 commits into from
Closed

feat(adr): core metadata CPE #724

wants to merge 2 commits into from

Conversation

jpwhitemn
Copy link
Member

Signed-off-by: jpwhitemn jpwhite_mn@yahoo.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)

@jpwhitemn
feat(adr): draft outline of CPE
75ea696 
Signed-off-by: jpwhitemn <jpwhite_mn@yahoo.com>
@jpwhitemn jpwhitemn added documentation hold Intended for PRs we want to flag for ongoing review ADR Architecture Decision Record labels Apr 5, 2022
@jpwhitemn jpwhitemn marked this pull request as draft April 5, 2022 00:27
@jpwhitemn
feat(adr): full ADR based on feedback of draft review in app services WG
eef96a3 
Signed-off-by: jpwhitemn <jpwhite_mn@yahoo.com>
@jpwhitemn jpwhitemn marked this pull request as ready for review April 22, 2022 22:55
@jpwhitemn jpwhitemn removed the hold Intended for PRs we want to flag for ongoing review label Apr 22, 2022
@jpwhitemn jpwhitemn changed the title feat(adr): draft outline of CPE feat(adr): core metadata CPE Apr 22, 2022
@lenny-goodell lenny-goodell mentioned this pull request Apr 28, 2022
Merged
4 tasks
@weichou1229
Copy link
Member

It seems the metadata will send the CPE instead of adding a notification when a device has been added, updated, or deleted
https://github.com/edgexfoundry/edgex-go/blob/ff693608c36af4ab72a5c512cfc781335cb747c6/internal/core/metadata/application/notify.go#L60

@jpwhitemn jpwhitemn added the levski fall 2022 release label Apr 29, 2022
@jpwhitemn jpwhitemn added this to the Levski milestone Apr 29, 2022
@jpwhitemn
Copy link
Member Author

per TSC meeting of 7/27/22 - decision to close this one as it is now covered by PR #795

@jpwhitemn jpwhitemn closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ADR Architecture Decision Record documentation levski fall 2022 release
Projects
None yet
Milestone
Levski
Development

Successfully merging this pull request may close these issues.
2 participants
@jpwhitemn @weichou1229