Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use released SDK version in App Template #1428

Merged

Conversation

lenny-goodell
Copy link
Member

fixes #1427

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A existing suffice
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

Temporary comment out the replace statement in the go.mod file
run make build from app-service-template folder
verify service builds
run make test from app-service-template folder
verify all tests pass

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell force-pushed the sdk-version-template-main branch from e416a3e to dcb9506 Compare June 13, 2023 21:15
fixes edgexfoundry#1427

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell force-pushed the sdk-version-template-main branch from dcb9506 to 67af729 Compare June 13, 2023 21:15
@lenny-goodell lenny-goodell merged commit 34e8d8f into edgexfoundry:main Jun 13, 2023
@lenny-goodell lenny-goodell deleted the sdk-version-template-main branch June 13, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App-service example not working (SDK version incorrect)
2 participants