Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new ReadingClient API to service and context #1482

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Sep 20, 2023

closes #1476

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) Unit tests suffice
  • I have opened a PR for the related docs change (if not, why?)
    feat: Document new ReadingClient APIs edgex-docs#1233

Testing Instructions

New Dependency Instructions (If applicable)

closes edgexfoundry#1476

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Copy link
Contributor

@vli11 vli11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1482 (78362c1) into main (180f158) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #1482      +/-   ##
==========================================
+ Coverage   66.89%   66.93%   +0.04%     
==========================================
  Files          35       35              
  Lines        3072     3076       +4     
==========================================
+ Hits         2055     2059       +4     
  Misses        881      881              
  Partials      136      136              
Files Changed Coverage Δ
internal/app/service.go 59.61% <100.00%> (+0.22%) ⬆️
internal/appfunction/context.go 91.26% <100.00%> (+0.14%) ⬆️

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell changed the title feat: Add new ReadingClient API to sevice and context feat: Add new ReadingClient API to service and context Sep 20, 2023
@lenny-goodell lenny-goodell merged commit 94620e0 into edgexfoundry:main Sep 20, 2023
@lenny-goodell lenny-goodell deleted the reading-client branch September 20, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide ReadingClient() from interfaces.ApplicationService
4 participants