Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide ReadingClient() from interfaces.ApplicationService #1476

Closed
jrtitus opened this issue Sep 13, 2023 · 1 comment · Fixed by #1482
Closed

Provide ReadingClient() from interfaces.ApplicationService #1476

jrtitus opened this issue Sep 13, 2023 · 1 comment · Fixed by #1482
Labels
enhancement New feature or request
Milestone
Napa

Comments

@jrtitus
Copy link
Contributor

jrtitus commented Sep 13, 2023

🚀 Feature Request

Relevant Package [REQUIRED]

interfaces

Relevant files to change would be:

  • pkg/interfaces/service.go
  • pkg/interfaces/mocks/ApplicationService.go
  • internal/app/service.go

Description [REQUIRED]

interfaces.ApplicationService provides access to several client instances. ReadingClient is not one of them.

Describe the solution you'd like

Add ReadingClient to the list of available clients from interfaces.ApplicationService

Describe alternatives you've considered

I have also considered using EventClient and filtering readings data manually, but the functions of ReadingClient are more convenient to retrieve the data.
@jrtitus jrtitus added the enhancement New feature or request label Sep 13, 2023
@lenny-goodell lenny-goodell added this to the Napa milestone Sep 13, 2023
@lenny-goodell lenny-goodell moved this to New Issues in Application Services Sep 13, 2023
@lenny-goodell lenny-goodell moved this from New Issues to Napa Release Backlog in Application Services Sep 20, 2023
@lenny-goodell lenny-goodell moved this from Napa Release Backlog to In Progress in Application Services Sep 20, 2023
lenny-goodell pushed a commit to lenny-goodell/app-functions-sdk-go that referenced this issue Sep 20, 2023
feat: Add new ReadingClient API to sevice and context
78362c1 
closes edgexfoundry#1476

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell mentioned this issue Sep 20, 2023
Merged
5 tasks
@lenny-goodell lenny-goodell moved this from In Progress to In Review in Application Services Sep 20, 2023
lenny-goodell pushed a commit that referenced this issue Sep 20, 2023
feat: Add new ReadingClient API to service and context (#1482)
94620e0 
* feat: Add new ReadingClient API to service and context

closes #1476

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@github-project-automation github-project-automation bot moved this from In Review to Done in Application Services Sep 20, 2023
@lenny-goodell
Copy link
Member

@jrtitus , implemented. Will be in the upcoming Napa release in November.

@lenny-goodell lenny-goodell moved this from Done to Previously Done in Application Services Oct 3, 2023
@jrtitus jrtitus mentioned this issue Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Application Services
Archived in project
Milestone
Napa
Development

Successfully merging a pull request may close this issue.

feat: Add new ReadingClient API to service and context lenny-goodell/app-functions-sdk-go
2 participants
@jrtitus @lenny-goodell