coordinator: enable returning seed to user #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
force-pushed
the
burgerdev/move-userapi
branch
from
a7335ce to
cf571cd
Compare
burgerdev
force-pushed
the
burgerdev/seed-to-user
branch
from
7d7610a to
9ea2a06
Compare
burgerdev
changed the title
burgerdev
force-pushed
the
burgerdev/seed-to-user
branch
from
9ea2a06 to
cbdf93f
Compare
burgerdev
changed the title
katexochen
approved these changes
Jun 20, 2024
burgerdev
force-pushed
the
burgerdev/seed-to-user
branch
from
cbdf93f to
4e562fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates
Authority.setManifest(authority) andAuthority.SetManifest(userapi) after the refactoring in #583. This is more or less a move of the function body from one file to another, except that the generated seed could now be returned to the user (for that to work, however, bae8e7f needs to change theManifestdefinition first).I tried to ensure that all test cases removed from
authority_test.goare reflected inuserapi_test.go, and it turned out we already covered most of it there.