Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: check measurements reproducibility test for images #3654

Merged
merged 51 commits into from
Mar 6, 2025
Merged

e2e: check measurements reproducibility test for images #3654

merged 51 commits into from
Mar 6, 2025

Conversation

miampf
Copy link
Contributor

@miampf miampf commented Feb 18, 2025

Context

Currently, we are not testing if the measurements of released images can be reproduced.

Proposed change(s)

  • Add ./.github/workflows/check_measurements_reproducibility.yml that runs as part of the release workflow or on workflow_dispatch

Additional info

Checklist

  • Run the E2E tests that are relevant to this PR's changes
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?

@miampf miampf added the no changelog Change won't be listed in release changelog label Feb 18, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 18, 2025 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 4ab06db
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/67c973a1bc3129000806d5a0

@miampf miampf marked this pull request as ready for review February 18, 2025 13:05
@miampf miampf force-pushed the miampf/e2e/test-release-reproducibility branch 4 times, most recently from 3fffdf7 to db8a529 Compare February 25, 2025 11:09
@miampf
Copy link
Contributor Author

miampf commented Feb 25, 2025

New successful run with split up steps

@miampf miampf requested a review from daniel-weisse February 25, 2025 12:05
@miampf miampf force-pushed the miampf/e2e/test-release-reproducibility branch from bb2e108 to 9508804 Compare February 27, 2025 09:21
daniel-weisse
daniel-weisse approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my side

@miampf miampf force-pushed the miampf/e2e/test-release-reproducibility branch from a443646 to fd77fba Compare March 4, 2025 10:50
@miampf
Copy link
Contributor Author

miampf commented Mar 4, 2025

New run with changes

@miampf miampf force-pushed the miampf/e2e/test-release-reproducibility branch 3 times, most recently from f9d0abe to a04c17e Compare March 4, 2025 11:51
burgerdev
burgerdev approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

miampf added 27 commits March 6, 2025 11:05
@miampf
fix shellcheck issues
affc11b
@miampf
split workflow into multiple steps
2468f19
@miampf
set -euo pipefail & use github outputs
70c4ce8
@miampf
Set extglob at correct step
05bdc77
@miampf
Only select required field
c42cbad
@miampf
Collect all errors before exiting
4097bb8
@miampf
Please shellcheck
96b139d
@miampf
Remove test error
bc53ac5
@miampf
Split inputs into version and ref
b3c2301
@miampf
made description for workflow_dispatch more helpful
e869db4
@miampf
remove -u from Compare measurements step
0e31386
@miampf
expand !! manually to help shellcheck
971ea5f
@miampf
refactor check for errors
4ba4002
@miampf
Fix typo
eae24c4
@miampf
split workflow into action
633bde2
@miampf
double checkout
e7b0a65
@miampf
add shell parameters
da3f58b
@miampf
don't delete scripts on checkout
855c522
@miampf
chmod +x
1859a4a
@miampf
tidy
63eb85b
@miampf
use action in release
9c7fc95
@miampf
implement jq suggestions
69864e8
@miampf
fix release workflow file
e02b367
@miampf
implement suggested shell changes
8f65b1f
@miampf
correct preserve env
6c44115
@miampf
implement more suggestions
65eea7f
@miampf
add forgotten runs-on to job in release workflow
4ab06db
@miampf miampf force-pushed the miampf/e2e/test-release-reproducibility branch from a04c17e to 4ab06db Compare March 6, 2025 10:06
@miampf miampf merged commit ddbcda8 into main Mar 6, 2025
7 checks passed
@miampf miampf deleted the miampf/e2e/test-release-reproducibility branch March 6, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burgerdev burgerdev burgerdev approved these changes

@daniel-weisse daniel-weisse Awaiting requested review from daniel-weisse

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miampf @burgerdev @daniel-weisse