Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(container): use uuid instead of strings #471

Merged

Conversation

joshuachp
Copy link
Collaborator

Parse the uuid when converting the event.

@joshuachp
Copy link
Collaborator Author

I am splitting the bigger PR of the database in smaller ones to make it more manageable.

@joshuachp joshuachp requested a review from harlem88 December 19, 2024 16:45
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 57.89474% with 16 lines in your changes missing coverage. Please review.

Project coverage is 53.1%. Comparing base (a90ae4d) to head (a90dacc).
Report is 2 commits behind head on release-0.9.

Files with missing lines Patch % Lines
...ehog-device-runtime-containers/src/requests/mod.rs 56.5% 10 Missing ⚠️
...gehog-device-runtime-containers/src/service/mod.rs 14.2% 6 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...-device-runtime-containers/src/docker/container.rs 42.9% <100.0%> (ø)
...evice-runtime-containers/src/requests/container.rs 80.0% <100.0%> (ø)
...vice-runtime-containers/src/requests/deployment.rs 54.5% <ø> (ø)
...og-device-runtime-containers/src/requests/image.rs 100.0% <ø> (ø)
...-device-runtime-containers/src/requests/network.rs 100.0% <ø> (ø)
...g-device-runtime-containers/src/requests/volume.rs 100.0% <ø> (ø)
...gehog-device-runtime-containers/src/service/mod.rs 10.5% <14.2%> (-0.6%) ⬇️
...ehog-device-runtime-containers/src/requests/mod.rs 68.0% <56.5%> (-11.1%) ⬇️

@joshuachp joshuachp force-pushed the refactor/use-uuid branch 11 times, most recently from 17a1a4a to dced497 Compare January 16, 2025 08:58
Parse the uuid when converting the event.

Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
@harlem88 harlem88 merged commit 158ce6a into edgehog-device-manager:release-0.9 Jan 16, 2025
18 checks passed
@joshuachp joshuachp deleted the refactor/use-uuid branch January 16, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants