Implement support for vector type #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vectors get decoded into array.array. Encoding supports any list-like array of numbers, but has an optimized fast path for things like array and ndarray that avoids needing to box integers. The test passes when run against the current `pgvector` branch with edgedb/edgedb#5620 applied to it.
tailhook
reviewed
Jun 8, 2023
1st1
reviewed
Jun 8, 2023
1st1
approved these changes
Jun 8, 2023
fantix
pushed a commit
that referenced
this pull request
Jun 18, 2023
Vectors get decoded into array.array. Encoding supports any list-like array of numbers, but has an optimized fast path for things like array and ndarray that avoids needing to box integers.
Merged
fantix
pushed a commit
that referenced
this pull request
Jun 19, 2023
Vectors get decoded into array.array. Encoding supports any list-like array of numbers, but has an optimized fast path for things like array and ndarray that avoids needing to box integers.
fantix
added a commit
that referenced
this pull request
Jun 21, 2023
Changes ======= * Add --dir option to codegen for searching .edgeql files (#434) (by @fantix in ec90e35 for #434) * Implement support for vector type (#439 #440) (by @msullivan in 0bee718 for #439, 50a25ef for #440) * Lowercase org/instance name when computing Cloud instance DNS (#441) (by @elprans in 0f30b26 for #441) * Implement `database` config in project dir (#442) (by @tailhook in bee7327 for #442)
Merged
fantix
added a commit
that referenced
this pull request
Jun 22, 2023
Changes ======= * Add --dir option to codegen for searching .edgeql files (#434) (by @fantix in ec90e35 for #434) * Implement support for vector type (#439 #440) (by @msullivan in 0bee718 for #439, 50a25ef for #440) * Lowercase org/instance name when computing Cloud instance DNS (#441) (by @elprans in 0f30b26 for #441) * Implement `database` config in project dir (#442) (by @tailhook in bee7327 for #442)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vectors get decoded into array.array. Encoding supports any list-like
array of numbers, but has an optimized fast path for things like array
and ndarray that avoids needing to box integers.
The test passes when run against the current
pgvectorbranch withedgedb/edgedb#5620 applied to it.