Wait for ingress traffic before shutting down #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, if the application within the enclave exited shortly after sending a particularly slow (e.g. large) response, the ingress proxy tasks would be aborted before the transfer could complete, causing the response to be prematurely terminated. Instead of aborting the tasks, send a shutdown signal and wait for their completion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if the application within the enclave exited
shortly after sending a particularly slow (e.g. large) response, the
ingress proxy tasks would be aborted before the transfer could
complete, causing the response to be prematurely terminated. Instead
of aborting the tasks, send a shutdown signal and wait for their
completion.
This fixes #167.