Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink the size of thisamericanlife.svg by optimizing path #498

Merged
merged 2 commits into from
Dec 12, 2020
Merged

Shrink the size of thisamericanlife.svg by optimizing path #498

merged 2 commits into from
Dec 12, 2020

Conversation

zfrohardt
Copy link
Collaborator

By rearranging the order of commands in the <path> element, we can shrink the overall size from 309 bytes to 302 bytes.

@zfrohardt
Copy link
Collaborator Author

My apologies, I am using this repository as a way to learn how to contribute to open source projects, and I did not realize that by pushing to master I would be adding commits to this pull request. I will make feature branches from now on

@edent
Copy link
Owner

edent commented Nov 26, 2020

That's OK - we all have to learn somewhere.

Could you please check the Vivino one against the reference icon? Your new version looks different from our original.

@zfrohardt
Copy link
Collaborator Author

From what I can tell, my version is closer to the official reference file than the one that I modified. In the previous version, there were lots of misalignments peppered throughout.

If you look at the reference file, all of the circles are placed along a sort of standardized grid system, where each circle is equidistant to each of their closest neighbors. Each circle is exactly aligned with every other circle in the same row and column. My version replicates this design and fixes some of the sloppiness in the previous version

@zfrohardt
Copy link
Collaborator Author

Would you like me to make a separate pull request for altering vivino.svg? The current icon can be shrunk without any changes to the icon. I just also happen to think that the current icon's fidelity can be improved

@edent
Copy link
Owner

edent commented Dec 2, 2020

Sounds good.

@edent edent merged commit e637093 into edent:master Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants