Ubuntu.svg patch #490
Closed
Ubuntu.svg patch #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on btrem's work
btrem
added a commit
to btrem/SuperTinyIcons
that referenced
this pull request
Nov 15, 2020
Based on @Erwan-le-Gall improvement in edent#490 , this commit changes the fill in the large `circle` from the same color as the containing `rect` to `none`, shaving off 3 bytes.
|
Your patch breaks the format of contributions to this repo. See the contributing guidelines for this repo for details. I edit ubuntu.svg in my branch to incorporate your change. Thanks for the suggestion. |
|
Salut @Erwan-le-Gall & merci beaucoup! Please add line breaks to make it a bit more readable. |
|
The patch that @Erwan-le-Gall submitted is nearly identical to the original commit 52b16ff in pull request #487. @Erwan-le-Gall notice that I used a hex color value for a fill attribute where I could have used none, saving 3 bytes. His patch makes that change. I incorporated it into my pull request as commit 7af7c3c. You can just pull #487 if it looks ok. |
edent
pushed a commit
that referenced
this pull request
Nov 26, 2020
* Shrinks ubuntu.svg Uses 1 circle with stroke for main ring instead of 2 separate circles. Simplifies path. * Changes fill in outer circle to none Based on @Erwan-le-Gall improvement in #490 , this commit changes the fill in the large `circle` from the same color as the containing `rect` to `none`, shaving off 3 bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on btrem's work