New google icons #469

jonatjano · 2020-10-26T22:13:22Z

I added the 5 new google logos

closes #458

edent · 2020-10-28T08:52:05Z

images/svg/gmail.svg

 viewBox="0 0 512 512"><rect
 width="512" height="512"
 rx="15%"
-fill="#fff"/><path fill="#f2f2f2" d="M120 392V151.075h272V392"/><path fill-opacity=".05" d="M256 285L120 392l-4-212"/><path fill="#d54c3f" d="M120 392H97c-12 0-22-10-22-23V143h45z"/><path fill-opacity=".08" d="M317 392h77V159H82"/><path fill="#f2f2f2" d="M97 121h318L256 234"/><path fill="#b63524" d="M392 392h23c12 0 22-10 22-23V143h-45z"/><path fill="none" stroke="#de5145" stroke-linecap="round" stroke-width="44" d="M97 143l159 115 159-115"/></svg>
+fill="white"/><path d="M158 391v-140l-82-63V361q0 30 30 30" fill="#4285f4"/><path d="M76 188l82 63v-98l-30-23c-27-21-52 0-52 26" fill="#c5221f"/><path d="M158 251l98 74l98-74v-98l-98 74l-98-74" fill="#ea4335"/><path d="M436 188l-82 63v-98l30-23c27-21 52 0 52 26" fill="#fbbc04"/><path d="M354 391v-140l82-63V361q0 30-30 30" fill="#34a853"/></svg>


#fff is shorter than white

edent · 2020-10-28T08:52:33Z

images/svg/gmail.svg

@@ -1,6 +1,6 @@
 <svg xmlns="http://www.w3.org/2000/svg"
-aria-label="Gmail" role="img"
+aria-label="google gmail" role="img"


I think just Gmail is fine.

edent · 2020-10-28T08:53:07Z

images/svg/google_drive.svg

@@ -1,8 +1,6 @@
 <svg xmlns="http://www.w3.org/2000/svg"
-aria-label="Google Drive" role="img"
+aria-label="google drive" role="img"


Keep the capitalisation, please.

edent · 2020-10-28T08:53:45Z

images/svg/google_meet.svg

+width="512" height="512"
+rx="15%"
+fill="white"/><path d="M76 106h360v300h-360z" fill="transparent" stroke="white"/><path d="M166 106v90h-90" fill="#ea4335"/><path d="M166 106v90h120v60l90-73v-47q0-30-30-30" fill="#ffba00"/><path d="M286 256l90-73v146" fill="#00832d"/>
+<path d="M376 183l42-34c9-7 18-7 18 7v200c0 14-9 14-18 7l-42-34" fill="#00ac47"/>


These newlines can be removed.

jonatjano · 2020-10-28T12:52:51Z

I did the requested change, it should be good now.

Forrest-J

"Google collaborative content tools" should be "Google Docs Editors"

jonatjano · 2020-10-28T14:52:26Z

@Forrest-J if you look on https://www.blog.google/press/ you'll see that Google Docs still has the blue icon :

Forrest-J · 2020-10-28T18:51:27Z

In some places & historically Google also calls the suite itself "Google Docs Editors" as opposed to "Google Docs", the word processor. See also Wikipedia.

jonatjano · 2020-10-28T19:02:35Z

I didn't know that, I wonder what would be the best way of solving this.

I can imagine 4 possible solutions :

keep Collaborative content tools, user may search Docs editor
rename it Docs Editors, user may search collaborative content tools
have both, need to modify both when editing
make a symlink, one of the two will have the wrong aria-label

I think 3) has the lesser drawback since google shouldn't change the icon again for a while, nor change it multiple times in a short period of time

edent · 2020-10-28T22:00:32Z

I say option 3. I'm also thinking about keeping the older versions as an option. Just in case Google changes its mind.

jonatjano · 2020-10-28T22:03:01Z

We'll keep the older version anyways since it's not Google Docs which got the new icon but Google Docs Editor, this one refers to the whole suite (Docs, Calc, Slides, ...)

Forrest-J · 2020-10-28T22:54:06Z

Also from how I understand it "Collaborative content tools" isn't the proper name but just a descriptor given that it is set in sentence case, whereas "Google Docs Editors" is the proper name.

…itors.svg

logiclrd · 2020-10-30T06:42:06Z

images/svg/gmail.svg

@@ -3,4 +3,4 @@ aria-label="Gmail" role="img"
 viewBox="0 0 512 512"><rect
 width="512" height="512"
 rx="15%"
-fill="#fff"/><path fill="#f2f2f2" d="M120 392V151.075h272V392"/><path fill-opacity=".05" d="M256 285L120 392l-4-212"/><path fill="#d54c3f" d="M120 392H97c-12 0-22-10-22-23V143h45z"/><path fill-opacity=".08" d="M317 392h77V159H82"/><path fill="#f2f2f2" d="M97 121h318L256 234"/><path fill="#b63524" d="M392 392h23c12 0 22-10 22-23V143h-45z"/><path fill="none" stroke="#de5145" stroke-linecap="round" stroke-width="44" d="M97 143l159 115 159-115"/></svg>
+fill="#fff"/><path d="M158 391v-140l-82-63V361q0 30 30 30" fill="#4285f4"/><path d="M76 188l82 63v-98l-30-23c-27-21-52 0-52 26" fill="#c5221f"/><path d="M158 251l98 74l98-74v-98l-98 74l-98-74" fill="#ea4335"/><path d="M436 188l-82 63v-98l30-23c27-21 52 0 52 26" fill="#fbbc04"/><path d="M354 391v-140l82-63V361q0 30-30 30" fill="#34a853"/></svg>


There seems to be an imperfection between the dark and the light red, a subpixel band of white peeking through.

I can't find it when I zoom in, and all the shapes are specified in coordinates given in whole numbers, so it must be a rendering quirk, but:

logiclrd · 2020-10-30T06:50:02Z

images/svg/google_meet.svg

+viewBox="0 0 512 512"><rect
+width="512" height="512"
+rx="15%"
+fill="#fff"/><path d="M76 106h360v300h-360z" fill="transparent" stroke="white"/><path d="M166 106v90h-90" fill="#ea4335"/><path d="M166 106v90h120v60l90-73v-47q0-30-30-30" fill="#ffba00"/><path d="M286 256l90-73v146" fill="#00832d"/><path d="M376 183l42-34c9-7 18-7 18 7v200c0 14-9 14-18 7l-42-34" fill="#00ac47"/><path d="M166 406v-90h120v-60l90 73v47q0 30-30 30" fill="#00ac47"/><path d="M76 316v60q0 30 30 30h60v-90" fill="#0066da"/><path d="M76 196h90v120h-90" fill="#2684fc"/></svg>


I see it in this one too:

jonatjano · 2020-10-30T20:24:23Z

It shouldn't happens, definitely a rendering quirk, I'll try to see if there is a way to avoid this when I have a little time. Probably not this weekend, I got a rush for a school project.

jonatjano added 3 commits October 26, 2020 22:59

new google icons

b7acae8

broken links in readme

6ece0bc

removed extra new lines breaking the table

dc10c1f

edent reviewed Oct 28, 2020

View reviewed changes

Jonathan Selle and others added 3 commits October 28, 2020 10:04

resolved reviews

64b5fe9

Updated README.md

ebb68ba

replaced white by #fff in google colaborative content tools

60d4c54

Forrest-J reviewed Oct 28, 2020

View reviewed changes

duplicated google_collaborative_content_tools.svg into google_docs_ed…

174b7f5

…itors.svg

logiclrd reviewed Oct 30, 2020

View reviewed changes

reduced rendering quirk

60b5e72

edent merged commit 06ccc4d into edent:master Nov 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New google icons #469

New google icons #469

jonatjano commented Oct 26, 2020

edent Oct 28, 2020

edent Oct 28, 2020

edent Oct 28, 2020

edent Oct 28, 2020

jonatjano commented Oct 28, 2020

Forrest-J left a comment

jonatjano commented Oct 28, 2020 •

edited

Loading

Forrest-J commented Oct 28, 2020

jonatjano commented Oct 28, 2020

edent commented Oct 28, 2020

jonatjano commented Oct 28, 2020

Forrest-J commented Oct 28, 2020

logiclrd Oct 30, 2020

logiclrd Oct 30, 2020

logiclrd Oct 30, 2020

jonatjano commented Oct 30, 2020 •

edited

Loading

New google icons #469

New google icons #469

Conversation

jonatjano commented Oct 26, 2020

edent Oct 28, 2020

Choose a reason for hiding this comment

edent Oct 28, 2020

Choose a reason for hiding this comment

edent Oct 28, 2020

Choose a reason for hiding this comment

edent Oct 28, 2020

Choose a reason for hiding this comment

jonatjano commented Oct 28, 2020

Forrest-J left a comment

Choose a reason for hiding this comment

jonatjano commented Oct 28, 2020 • edited Loading

Forrest-J commented Oct 28, 2020

jonatjano commented Oct 28, 2020

edent commented Oct 28, 2020

jonatjano commented Oct 28, 2020

Forrest-J commented Oct 28, 2020

logiclrd Oct 30, 2020

Choose a reason for hiding this comment

logiclrd Oct 30, 2020

Choose a reason for hiding this comment

logiclrd Oct 30, 2020

Choose a reason for hiding this comment

jonatjano commented Oct 30, 2020 • edited Loading

jonatjano commented Oct 28, 2020 •

edited

Loading

jonatjano commented Oct 30, 2020 •

edited

Loading