Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humble Bundle icon #444

Merged
merged 9 commits into from
Oct 9, 2020
Merged

Humble Bundle icon #444

merged 9 commits into from
Oct 9, 2020

Conversation

The24thDS
Copy link
Contributor

This should take care of a part of #362

@edent
Copy link
Owner

edent commented Oct 8, 2020

That's really close, but not quite right. If you set rx="50%" you'll see that the red stick goes outside the bounds.
A broken image
Take a look at the guideline SVG in the Contributing file - that should help.

@The24thDS
Copy link
Contributor Author

Now it should be fine :)

@admvx
Copy link
Collaborator

admvx commented Oct 8, 2020

Thanks for the update @The24thDS :) I think the centering is better now, but the icon is too large with respect to the guide SVG:

image

Plus one naming issue from the contributing doc:

Filename should be nameofservice.svg - all in lower-case. If a special character must be used, please replace it with an underscore (not a dot nor a dash).

@The24thDS
Copy link
Contributor Author

You are right. I will fix these as soon as I have some free time.

@The24thDS
Copy link
Contributor Author

Can you check it now @edent?

@edent
Copy link
Owner

edent commented Oct 9, 2020

Lovely stuff. Well done!

@edent edent merged commit 3d53f9a into edent:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants