add: HAML, fix #307 #340
Merged
add: HAML, fix #307 #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
The logo has been aggressively simplified to fit under 1KiB, it look more like the favicon than the full quality one.
romain-dartigues
force-pushed
the
add-haml
branch
from
d78486d to
0716468
Compare
edent
reviewed
Oct 24, 2019
images/svg/haml.svg
Outdated
| viewBox="-11 -11 512 512"><rect | ||
| width="490" height="490" | ||
| rx="15%" | ||
| stroke="#29291c" stroke-width="22" |
There was a problem hiding this comment.
I'm not sure about the stroke around the edge. Unless that's part of the original design?
Rest looks pretty good though!
There was a problem hiding this comment.
I'm not sure about the stroke around the edge. Unless that's part of the original design?
How about now?
If you consider their favicon to be their "original design", yes it was (but barely visible at it's size).
|
This is great! I've just noticed that some renderers require "xmlns:x=..." to be `xmlns:xlink..." That'll bump up the file sizes of a few, but I'll take care of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logo has been aggressively simplified to fit under 1KiB,
it look more like the favicon than the full quality one.