Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Facebook Messenger svg and android drawable #337

Merged
merged 8 commits into from
Oct 21, 2019

Conversation

jmb
Copy link
Contributor

@jmb jmb commented Oct 21, 2019

No description provided.

@edent
Copy link
Owner

edent commented Oct 21, 2019

This looks great! Could I please ask you to make two adjustments - one small, one large?

Firstly, could you format the SVG as per the template at https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md

<svg
xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><rect
width="512" height="512"
rx="15%"
fill="#fff"/>...</svg>

That helps keep the file small and makes it easier for us to see future changes to the icon.

Secondly.... The main icon is wrapped in <g transform="translate(68.684 73.967) scale(.36585)"> - you may be able to make the filesize smaller by recalculating the paths.

I use http://petercollingridge.appspot.com/svg-transforms - but feel free to experiment.

Thanks for this - looking forward to merging.

@jmb
Copy link
Contributor Author

jmb commented Oct 21, 2019

I think this has done it (after a lot of battling with the tools and manually working out the gradient!). For reference, I also found this site which was helpful: https://lean-svg.netlify.com/

@edent edent merged commit 7d47e7e into edent:master Oct 21, 2019
@edent
Copy link
Owner

edent commented Oct 21, 2019

Good stuff! You'll notice that I remove some newlines to shrink the file even more.

@jmb
Copy link
Contributor Author

jmb commented Oct 21, 2019

Good stuff! You'll notice that I remove some newlines to shrink the file even more.

Thanks! Out of interest, why do you leave the new lines at the top?

@jmb jmb deleted the facebook-messenger branch October 23, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants