Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Ubiquiti Networks logo #321

Merged
merged 5 commits into from
Oct 18, 2019
Merged

Added Ubiquiti Networks logo #321

merged 5 commits into from
Oct 18, 2019

Conversation

vangyyy
Copy link
Contributor

@vangyyy vangyyy commented Oct 16, 2019

No description provided.

@edent
Copy link
Owner

edent commented Oct 18, 2019

Looks good, but please can you follow the template at https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md

We need the aria label for accessibility. And the layout helps with diffs.

<svg
xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><rect
width="512" height="512"
rx="15%"
fill="#fff"/>...</svg>

@vangyyy
Copy link
Contributor Author

vangyyy commented Oct 18, 2019

Will fix that, also for #324.

@edent
Copy link
Owner

edent commented Oct 18, 2019

Fab!

@edent edent merged commit 421e483 into edent:master Oct 18, 2019
@vangyyy vangyyy deleted the ubiquiti-icon branch October 18, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vangyyy @edent