-
-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves issue #282: Created and added iheartradio svg #306
Conversation
…by iheart radio - converted eps to svg
Please follow the contributing guide (file must be under 1 KiB, edit README.md, etc.). |
@romain-dartigues apologies. Small concern: My smallest possible SVG created for this was 2,225 bytes (2.2kb). I know this does not align with the goal of this project so I'm afraid I'm unable to complete this. |
How about just the red heart logo? Remove the text at the bottom. I reckon that will fit into the size limit. |
@edent that sounds great. Thank you. |
Alright @edent that reduced it by a tad over 50% and then added to reference and read me as per contribution guidelines. |
This seems to have removed the actual icon you're trying to submit. |
I had a little go at this by chopping it in half and using a transform to mirror... Down to 1116 bytes... https://github.com/jmb/SuperTinyIcons/blob/iheartradio/images/svg/iheartradio.svg Not sure it likes the transform on github... :( |
Fixed the transform, tried rounding and now down to 948 bytes... :) Will do a PR to your repo @HenrySabio then you can PR to the master if you like! |
That sounds good. Hopefully this version works fine. |
Yeah it's a bit tricky - I'm using Inkscape 1.0 and ended up just copy and pasting the SVG data as required! |
Fix for iheartradio icon size
@jmb this looks perfect! If you could just also update the needed associated files in the reference & readme and we should be good to go with a final commit |
I thought you could do that in your branch! ;) Can do it in a bit if you need me to though! |
@jmb I can! I just won't be able to until later tonight. I figured the issue/pr has been open for long enough I'm sure they'd like this resolved asap. But No problem! I'll have this taken care of. @edent Looks like We have the solution - I'll tag you when the final commit has been made and ready to merge! |
Ok, no prob will take a look shortly. @HenrySabio - done |
Teamwork makes the dream work :-) Tag me when it's ready to go! |
Created and added iheart radio svg using official art files provided by iheart radio - converted eps to svg