Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves issue #282: Created and added iheartradio svg #306

Merged
merged 18 commits into from
Oct 22, 2019
Merged

Resolves issue #282: Created and added iheartradio svg #306

merged 18 commits into from
Oct 22, 2019

Conversation

HenrySabio
Copy link
Contributor

Created and added iheart radio svg using official art files provided by iheart radio - converted eps to svg

@romain-dartigues
Copy link
Collaborator

Please follow the contributing guide (file must be under 1 KiB, edit README.md, etc.).

@HenrySabio
Copy link
Contributor Author

@romain-dartigues apologies.
I uploaded the wrong file but I also admit I neglected to proper ready the contributing guide.

Small concern: My smallest possible SVG created for this was 2,225 bytes (2.2kb).
Upon further research other people who have attempted the same for this logo have only been able to reduce to the same exact size. With gzip compression it can only be brought to about 1.18kb.

I know this does not align with the goal of this project so I'm afraid I'm unable to complete this.
If it's possible at all.

@edent
Copy link
Owner

edent commented Oct 14, 2019

How about just the red heart logo? Remove the text at the bottom. I reckon that will fit into the size limit.

@HenrySabio
Copy link
Contributor Author

@edent that sounds great.
I’ll do that and update the remaining files as per the contribution guidelines today!

Thank you.

@HenrySabio
Copy link
Contributor Author

Alright @edent that reduced it by a tad over 50% and then added to reference and read me as per contribution guidelines.

@edent
Copy link
Owner

edent commented Oct 18, 2019

This seems to have removed the actual icon you're trying to submit.

@jmb
Copy link
Contributor

jmb commented Oct 21, 2019

I had a little go at this by chopping it in half and using a transform to mirror... Down to 1116 bytes... https://github.com/jmb/SuperTinyIcons/blob/iheartradio/images/svg/iheartradio.svg

Not sure it likes the transform on github... :(

@jmb
Copy link
Contributor

jmb commented Oct 21, 2019

Fixed the transform, tried rounding and now down to 948 bytes... :) Will do a PR to your repo @HenrySabio then you can PR to the master if you like!

@HenrySabio
Copy link
Contributor Author

That sounds good.
I was able to get it down to a similar size but it would not longer open in illustrator when I tried rounding the numbers. It would open and preview fine everywhere else but would open as a blank canvas otherwise in illustrator.

Hopefully this version works fine.

@jmb
Copy link
Contributor

jmb commented Oct 21, 2019

Yeah it's a bit tricky - I'm using Inkscape 1.0 and ended up just copy and pasting the SVG data as required!

@edent edent removed the invalid label Oct 21, 2019
Fix for iheartradio icon size
@HenrySabio
Copy link
Contributor Author

@jmb this looks perfect! If you could just also update the needed associated files in the reference & readme and we should be good to go with a final commit

@jmb
Copy link
Contributor

jmb commented Oct 21, 2019

I thought you could do that in your branch! ;)

Can do it in a bit if you need me to though!

@HenrySabio
Copy link
Contributor Author

@jmb I can! I just won't be able to until later tonight. I figured the issue/pr has been open for long enough I'm sure they'd like this resolved asap. But No problem! I'll have this taken care of.

@edent Looks like We have the solution - I'll tag you when the final commit has been made and ready to merge!

@jmb
Copy link
Contributor

jmb commented Oct 21, 2019

Ok, no prob will take a look shortly.

@HenrySabio - done

@edent
Copy link
Owner

edent commented Oct 21, 2019

Teamwork makes the dream work :-)

Tag me when it's ready to go!

@edent edent merged commit d143622 into edent:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants