Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gradle icon #251

Merged
merged 8 commits into from
Oct 10, 2019
Merged

Add gradle icon #251

merged 8 commits into from
Oct 10, 2019

Conversation

hirakJS
Copy link
Contributor

@hirakJS hirakJS commented Oct 6, 2019

No description provided.

@edent
Copy link
Owner

edent commented Oct 6, 2019

Please can you provide a reference image? You can also shrink the size by simplifying the transform.

@hirakJS
Copy link
Contributor Author

hirakJS commented Oct 6, 2019

I've update the gradle icon with the new one. Also, I've added the reference image.
Please have a look.

@hirakJS
Copy link
Contributor Author

hirakJS commented Oct 7, 2019

Is this OK?

@edent
Copy link
Owner

edent commented Oct 9, 2019

Looks great! Could you do two small things, then I can merge.

  1. The nose has a weird bump, can it be smoothed?
    Screenshot_2019-10-09 Add gradle icon by hirakJS · Pull Request #251 · edent SuperTinyIcons

  2. Please can you add a white rectangle background like the other icons?

@hirakJS
Copy link
Contributor Author

hirakJS commented Oct 10, 2019

Changes are done. Also I've added it to README. Please have a look.

@edent
Copy link
Owner

edent commented Oct 10, 2019

Perfect! Thanks :-)

@edent edent merged commit 966f345 into edent:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hirakJS @edent