Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git icon #248

Closed
wants to merge 3 commits into from
Closed

Add git icon #248

wants to merge 3 commits into from

Conversation

hirakJS
Copy link
Contributor

@hirakJS hirakJS commented Oct 5, 2019

No description provided.

@hirakJS hirakJS changed the title Add Git Icon Add git & gradle icon Oct 6, 2019
@hirakJS hirakJS changed the title Add git & gradle icon Add git icon Oct 6, 2019
@edent
Copy link
Owner

edent commented Oct 6, 2019

Could you please make this fit in with the other icons? It should fit within a circle. You can also shrink the size by simplifying the transform.

@hirakJS
Copy link
Contributor Author

hirakJS commented Oct 6, 2019

done changes.

@romain-dartigues romain-dartigues mentioned this pull request Oct 7, 2019
Merged
@hirakJS
Copy link
Contributor Author

hirakJS commented Oct 7, 2019

Do I need to add the icon into README file?

@edent
Copy link
Owner

edent commented Oct 7, 2019

Yes, please add it to the README. If you can add a reference image as well, that would be great.

Good work on this!

@edent
Copy link
Owner

edent commented Oct 7, 2019

Fixed in #272

@edent edent closed this Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hirakJS @edent