Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Installation instructions #155

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Add Installation instructions #155

merged 1 commit into from
Jul 17, 2018

Conversation

limonte
Copy link

@limonte limonte commented Jul 16, 2018

Connected to #148

After the npm package has been released, it makes sense to inform users about it.

Copy link
Owner

@edent edent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please bump the package version to 0.01.02 and include some more detail about how/why to use the installed version.

Thanks!

@limonte
Copy link
Author

limonte commented Jul 17, 2018

Could you please bump the package version to 0.01.02

  • Firstly, that would be totally out of the scope of this PR, so I would rather create another PR after merging this one.
  • Secondly, why x.x.02? It should be x.x.01 as the current patch version is 0.
  • Thirdly, according to semver (which is the default way to do versioning for npm), it should be without leading zeros - 0.1.1.

I recommend reading the small docs about semver: https://docs.npmjs.com/misc/semver

include some more detail about how/why to use the installed version.

Well, I can add the answer on question how?, but not why? as the latest seems to be well-explained in the README already.

@edent
Copy link
Owner

edent commented Jul 17, 2018

Ah, sorry, I hadn't pushed my local changes. I've already published 0.1.2 (you are correct about semver).

If you can add some more about the how - that'd be great.

@limonte
Copy link
Author

limonte commented Jul 17, 2018

Will do 👍

* <a href="https://amzn.to/2o95rA8"><img src="https://edent.github.io/SuperTinyIcons/images/svg/amazon.svg" width="40" /> Gift me something from my Amazon Wishlist
* <a href="https://paypal.me/edent/gbp5"><img src="https://edent.github.io/SuperTinyIcons/images/svg/paypal.svg" width="40" /> Send me a tip
* <a href="https://edent.tel/"><img src="https://edent.github.io/SuperTinyIcons/images/svg/whatsapp.svg" width="40" /> Leave me a message
* <a href="https://amzn.to/2o95rA8"><img src="https://edent.github.io/SuperTinyIcons/images/svg/amazon.svg" width="40" /> Gift me something from my Amazon Wishlist</a>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closing </a> were missing here

README.md Outdated
<img src={logo} />
```

The demo repository with bootstrapped with `create-react-app`: [create-react-app-super-tiny-icons](https://github.com/limonte/create-react-app-super-tiny-icons)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to fork the demo repo to your account and update the link

@limonte
Copy link
Author

limonte commented Jul 17, 2018

If you can add some more about the how - that'd be great.

Done, take a look 👍

@edent edent merged commit a85b434 into edent:master Jul 17, 2018
romain-dartigues pushed a commit to romain-dartigues/SuperTinyIcons that referenced this pull request Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants