Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy button #34

Draft
wants to merge 5 commits into
base: production
Choose a base branch
from

Conversation

piqueen1
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Jul 16, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eddieantonio/syllabicsapp/j6u0uqcea
✅ Preview: https://syllabicsapp-git-fork-piqueen1-finnthye-3-copy-paste.eddieantonio.vercel.app

index.html Outdated
<label for="syl"> Syllabics </label>
<div class="syl-copy-line">
<label for="syl"> Syllabics </label>
<button class="copy-button">Copy Symbols</button>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should say syllabics!

Suggested change
<button class="copy-button">Copy Symbols</button>
<button class="copy-button">Copy syllabics</button>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you! I didn't know the target demographic's familiarity with linguistic terminology, only that my husband would recognize the implication of "symbol" faster than "character" or "syllabic" so it could make the user experience feel less linguisty. I was thinking the same about SRO, in case you wanted to modify or test that for our demographic; as a linguist myself, in love with orthographies, I didn't know what SRO meant until I read the explanation further down the site. Strange but true. Context clarifies the current use of both so these are just ideas I'm floating.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Culturally, the word "syllabics" means a lot! So it's definitely familiar to the intended audience. Frankly, "symbol" makes it sound somewhat insulting?

I agree with you about "SRO". This one is less well-known among the community members! I may de-emphasize the term, but I want to make it clear that we're using the standard orthography!

@piqueen1 piqueen1 marked this pull request as draft July 16, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants