fixing a bug with Ed-Fi 6.1 APIs dependencies #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not return resources in dependency order (requires sorting by an order property) and may contain duplicates of a given resource (one with Create operation, another with Update operation)
jayckaiser
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lightbeam uses the Ed-Fi API's dependencies endpoint to determine in which order to send resources. In Ed-Fi 5.1, this endpoint appears to have sorted resources in order. However E-d-Fi 6.1 produces the resources alphabetically. Moreover, it may show a resource twice (one with Create operation, another with Update operation), which caused lightbeam to send that resource twice.
This PR fixes this bug by filtering the list of resources returned by the dependencies endpoint to only those with a Create operation, and then sorting the resources according to the order property.