Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow deletion of students (if permitted by credential claimset and API auth strategy) #55

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

tomreitz
Copy link
Collaborator

@tomreitz tomreitz commented Oct 7, 2024

This PR removes the hard-coded prevention of lightbeam delete for students.

Note that if the Ed-Fi API uses a relationship-based authorization strategy, you may run into the following situation:

You run lightbeam delete, which deletes records from resources in dependency-order. Since studentEducationOrganizationAssociations depend on students, the stuEdOrgAssns are (successfully) deleted first. However, now your EdOrg no longer has any relationship to your students, so when lightbeam subsequently attempts to delete students, the API returns 403 unauthorized status codes. There is no way to delete these students with your API credentials.

If you see many 403 errors when lightbeam deleteing students, you may need to obtain new Ed-Fi API credentials with a different authorization strategy and try again.

@tomreitz tomreitz requested a review from jayckaiser October 7, 2024 19:37
@tomreitz tomreitz requested a review from johncmerfeld October 29, 2024 21:18
@tomreitz
Copy link
Collaborator Author

@johncmerfeld I don't think this is a controversial PR, it's just fixing this issue raised by Megan. I'm tagging you to review, if you don't mind. I think Jay has been too busy to review. I'm cleaning up open PRs. 😄 Thanks!

@tomreitz tomreitz merged commit 0e6cffe into main Nov 12, 2024
@tomreitz tomreitz deleted the fix/allow_delete_students branch November 12, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants