allow deletion of students (if permitted by credential claimset and API auth strategy) #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the hard-coded prevention of
lightbeam delete
forstudents
.Note that if the Ed-Fi API uses a relationship-based authorization strategy, you may run into the following situation:
You run
lightbeam delete
, which deletes records from resources in dependency-order. SincestudentEducationOrganizationAssociations
depend onstudents
, thestuEdOrgAssns
are (successfully) deleted first. However, now your EdOrg no longer has any relationship to your students, so when lightbeam subsequently attempts to deletestudents
, the API returns 403 unauthorized status codes. There is no way to delete these students with your API credentials.If you see many 403 errors when
lightbeam delete
ing students, you may need to obtain new Ed-Fi API credentials with a different authorization strategy and try again.