fixing bugs when some, but not all, custom API URLs are specified #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rlittle08 was trying to manually specify a
dependencies_url
but found a bug, that it doesn't work unless you also specify anoauth_url
. This PR fixes that, allowing any of the following to be manually specified to override the defaults discovered from thebase_url
:oauth_url
dependencies_url
open_api_metadata_url
or bothdescriptors_swagger_url
andresources_swagger_url
A future improvement might be to also allow a custom
dataManagementApi
URL (instead of constructing it inget_data_url()
), and to make themode
,year
, andversion
optional, since those can also be discovered from thebase_url
.Note that with these improvements, it is now theoretically possible to
validate
against a differentopen_api_metadata_url
then yousend
to (base_url
) in a singlelightbeam.yaml
and evenlightbeam validate+send
call. I'm not sure if anyone would ever need/want to do that, but it's possible.