Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing bugs when some, but not all, custom API URLs are specified #46

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

tomreitz
Copy link
Collaborator

@rlittle08 was trying to manually specify a dependencies_url but found a bug, that it doesn't work unless you also specify an oauth_url. This PR fixes that, allowing any of the following to be manually specified to override the defaults discovered from the base_url:

  • oauth_url
  • dependencies_url
  • open_api_metadata_url or both descriptors_swagger_url and resources_swagger_url

A future improvement might be to also allow a custom dataManagementApi URL (instead of constructing it in get_data_url()), and to make the mode, year, and version optional, since those can also be discovered from the base_url.

Note that with these improvements, it is now theoretically possible to validate against a different open_api_metadata_url then you send to (base_url) in a single lightbeam.yaml and even lightbeam validate+send call. I'm not sure if anyone would ever need/want to do that, but it's possible.

@tomreitz tomreitz requested a review from johncmerfeld July 18, 2024 14:45
@tomreitz tomreitz merged commit 8da8d8f into main Jul 23, 2024
@tomreitz tomreitz deleted the fix/custom_api_urls branch July 23, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants