Fix how hashlog entries are handled during deletes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the behavior of
lightbeam deleteso that hashlog entries are only removed after a confirmed successful delete. Fixes a bug where thehashvariable was used in a scope for which it was not defined.Also alter instances where
hashis used as a variable name. I don't think it's a good idea to use Python builtins as variable names in general, and in this particular case I think it may have contributed to this bug not being found -- to a code editor,hashis always defined, so there was no problem to highlight in the delete.py file