fixing a bug with per-request timeout #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k spends in the queue waiting for an available connection from the pool
ejoranlienea
approved these changes
Jun 13, 2023
jayckaiser
reviewed
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lightbeam sendworks by enqueueing requests (MAX_TASK_QUEUE_SIZE = 1000at a time) and then asynchronously processing the queue usingconfig.pool_sizeworkers.Previously, the per-request timeout "clock" started counting as soon as a request was enqueued, so it included all the time it waited in the queue for an available connection from the pool. If the queue size was large compared to
pool_sizeand/or the Ed-Fi API was particularly slow, you could wind up in an infinite loop where the aiohttp.RetryClient would perpetually timeout and requeue tasks, so lightbeam would never finish.This update changes the timeout behavior to measure time from when a request begins actually processing.