Feature/Include Contacts and Parents data in parent tables due to Ed-Fi rename #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
In Data Standard v5.0, Parents were renamed to Contacts. The new Contact entity is identical to the previous Parent entity with the addition of an optional GenderIdentity, PreferredFirstName, and PreferredLastName fields. StudentParentAssociations was also renamed to StudentContactAssociations. The goal of this PR is to get v5.0 data correctly incorporated into the model without doing the full naming shift from parents to contacts.
Note: These changes require this edu_edfi_source feature branch to be merged and released. The
packages.yml
file will need to be updated with this requirement.Breaking changes introduced by this PR:
Added three new columns to
dim_parent
that were introduced with the change to ContactsPR Merge Priority:
Changes to existing files:
fct_student_parent_association
,bld_ef3__parent_wide_emails
, andbld_ef3__parent_wide_phone_numbers
: source from the contacts staging tables, rename k_contact back to k_parentdim_parent
: source from the contacts staging tables, rename k_contact back to k_parent, and add three new columnsTests and QC done:
Ran in Stadium SCDE; confirmed that grain tests passed and row counts look correct.
edu_wh PR Review Checklist:
Make sure the following have been completed before approving this PR:
## New Features
for features, etc.Future ToDos & Questions:
We probably want to do a breaking change that completes the rename from Parents to Contacts here and in downstream systems. See the Slite doc for notes on what would be affected and how we might do this (configurable aliasing, etc.)