Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cohort year in dim_student #141

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Conversation

keenzarate213
Copy link
Contributor

@keenzarate213 keenzarate213 commented Jul 10, 2024

Description & motivation

Adding cohortYear in dim_student. This is from a collection (relevant staging PR that flattens this).

Relevant Monday item

PR Merge Priority:

  • Low
  • Medium
  • High

Changes to existing files:

  • dim_student: just adding cohort year build model and joining it
    left join stu_cohort_year
    on stu_demos.k_student = stu_cohort_year.k_student
    and stg_student.api_year = stu_cohort_year.school_year

New files created:

  • bld_ef3__student_cohort_years: to bring back to k_student grain after flattening the collection

Tests and QC done:

This branch has been tested in Boston and SC-district warehouse.

Future ToDos

No other collection in stuEdOrg needed to be flatten, there were other fields but non of them are populated in either Boston or SC yet. But in the future, could add those in as well

@keenzarate213 keenzarate213 marked this pull request as ready for review July 11, 2024 14:51
@keenzarate213 keenzarate213 requested a review from rlittle08 July 11, 2024 15:02
@rlittle08
Copy link
Collaborator

@keenzarate213 can you add a quick col description to dim_student.yaml for the new column?

@rlittle08
Copy link
Collaborator

How can we also incorporate cohortYears:schoolYear and cohortYears:Term into the warehouse? Maybe just keep as a variant object in dim_student for now?

@rlittle08 rlittle08 marked this pull request as draft September 13, 2024 15:16
@keenzarate213 keenzarate213 marked this pull request as ready for review September 16, 2024 17:06
@rlittle08 rlittle08 merged commit 2a0f36c into main Sep 16, 2024
@rlittle08 rlittle08 deleted the feature/stu_ed_org_collection branch September 16, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants