fix typo #90
Merged
fix typo #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncmerfeld
approved these changes
Jul 10, 2024
rlittle08
added a commit
that referenced
this pull request
Sep 19, 2024
* New DS5 optional fields for `Section`, `CourseTranscript`, and `StudentSectionAssociation` (#104) * add section_type * bring into line with correct json names * Update CHANGELOG.md --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org> * fix typo (#90) * fix typo * Update CHANGELOG.md --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org> * Feature/Contacts and StudentContactAssociations (#96) * redraft * add student contact associations * switch from parent to contact * add comments about name change * can't use gsn_skey * add note about new fields * update changelog * use dbt utils surrogate key * use parents if contacts are not enabled * add docs * remove configurability * extract extenstions configured with parent naming too * fix bad syntax --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org> * Bugfix/Updated Surrogate Keys to include lower() in student_unique_id inputs (#100) * added lower to student_unique_id in surrogate keys * Update stg_ef3__student_objective_assessments.sql * Update CHANGELOG.md --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org> * Feature/new DS5 optional fields on staff (#103) * add new optional fields * fix typo * Update CHANGELOG.md --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org> * flatten student cohort year (#92) * flatten student cohort year * grab school year and term * rename fields * Update CHANGELOG.md --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org> * explicitly call extract macro from this package (#98) * explicitly call extract macro from this package * Update CHANGELOG.md --------- Co-authored-by: John C. Merfeld <John.Merfeld@gmail.com> Co-authored-by: ejoranlienea <ejoranlien@edanalytics.org> Co-authored-by: Samantha LeBlanc <56237580+sleblanc23@users.noreply.github.com> Co-authored-by: Angelica Lastra <107369214+AngelicaLastra@users.noreply.github.com> Co-authored-by: keen <51969358+keenzarate213@users.noreply.github.com>
rlittle08
added a commit
that referenced
this pull request
Sep 20, 2024
… for grading periods v5.0) (#99) * draft of grading_period key change for v5.0 * update from main (#106) * New DS5 optional fields for `Section`, `CourseTranscript`, and `StudentSectionAssociation` (#104) * add section_type * bring into line with correct json names * Update CHANGELOG.md --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org> * fix typo (#90) * fix typo * Update CHANGELOG.md --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org> * Feature/Contacts and StudentContactAssociations (#96) * redraft * add student contact associations * switch from parent to contact * add comments about name change * can't use gsn_skey * add note about new fields * update changelog * use dbt utils surrogate key * use parents if contacts are not enabled * add docs * remove configurability * extract extenstions configured with parent naming too * fix bad syntax --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org> * Bugfix/Updated Surrogate Keys to include lower() in student_unique_id inputs (#100) * added lower to student_unique_id in surrogate keys * Update stg_ef3__student_objective_assessments.sql * Update CHANGELOG.md --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org> * Feature/new DS5 optional fields on staff (#103) * add new optional fields * fix typo * Update CHANGELOG.md --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org> * flatten student cohort year (#92) * flatten student cohort year * grab school year and term * rename fields * Update CHANGELOG.md --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org> * explicitly call extract macro from this package (#98) * explicitly call extract macro from this package * Update CHANGELOG.md --------- Co-authored-by: John C. Merfeld <John.Merfeld@gmail.com> Co-authored-by: ejoranlienea <ejoranlien@edanalytics.org> Co-authored-by: Samantha LeBlanc <56237580+sleblanc23@users.noreply.github.com> Co-authored-by: Angelica Lastra <107369214+AngelicaLastra@users.noreply.github.com> Co-authored-by: keen <51969358+keenzarate213@users.noreply.github.com> * add ods & dm version to every base table --------- Co-authored-by: John C. Merfeld <John.Merfeld@gmail.com> Co-authored-by: ejoranlienea <ejoranlien@edanalytics.org> Co-authored-by: Samantha LeBlanc <56237580+sleblanc23@users.noreply.github.com> Co-authored-by: Angelica Lastra <107369214+AngelicaLastra@users.noreply.github.com> Co-authored-by: keen <51969358+keenzarate213@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.