-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collapsible trade/single form #134
Conversation
Been a while! I'm returning to this and looking for some eyes on. I've resolved the conversations above to simplify future discussion, but feel free to look over what we talked about last fall. At any rate, I've caught this branch up to the current development branch. Then I focused only on adding a collapse feature to one form at the moment so we can focus better. Once we get it set, we can apply the feature to other routes in future PRs. So let's talk about the
Here are some photos to paint the big picture: |
@@ -9,7 +9,7 @@ interface Props { | |||
|
|||
const Checkbox = ({ register, label, checked }: Props) => ( | |||
<ChakraCheckbox {...register} defaultChecked={checked}> | |||
{label} | |||
<Text fontSize="sm">{label}</Text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -4,6 +4,7 @@ import { PropsWithChildren } from 'react'; | |||
|
|||
const CheckboxGroup = ({ children }: PropsWithChildren<{}>) => ( | |||
<Stack | |||
height={{ base: 'inherit', md: '40px', lg: '40px' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merged after waiting for review, >2 weeks |
All current forms collapse on submit, hiding optional inputs. This reduces noise in the UI so the user can better access the results of their form submissions. An arrow icon next to form submit buttons allow user to expand the form if they'd like to change values.