fix: fix lint problems and add ci workflow; invTransform NPE due to #1011 #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovilia
commented
Jan 23, 2024
| var tmp: T[] = []; | ||
|
|
||
| stackLength = length < 120 ? 5 : length < 1542 ? 10 : length < 119151 ? 19 : 40; |
There was a problem hiding this comment.
Unused parameter. I checked the original code that stackLength was used to init array but we don't use it so it can be safely removed.
plainheart
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CI to this repo and fix a potential bug of
invTransformbeing null since #1011